Issue 164350: Remove the unittest "DnsMasterTest.OsCachesLookupsTest"....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164350: Remove the unittest "DnsMasterTest.OsCachesLookupsTest".... (Closed)

Created:
11 years, 4 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, willchan no longer on Chromium, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove the unittest "DnsMasterTest.OsCachesLookupsTest". This test was checking that the system host resolver maintains an internal cache, by doing actual DNS resolves (which introduces a network dependency in the unit tests). This could be flaky on linux, which doesn't cache resolves. As of r18236 however, chromium maintains its own host cache. So the DNS prefetcher does not need to rely on the OS caching DNS resolves in order to be a win. BUG=http://crbug.com/18766 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23239

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -76 lines)			Patch
	M	chrome/browser/net/dns_master_unittest.cc	View	1 2 3	4 chunks	+5 lines, -72 lines	0 comments	Download
	M	net/base/mock_host_resolver.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 164350: Remove the unittest "DnsMasterTest.OsCachesLookupsTest".... (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add moar comment #

Patch Set 3 : Fix #

Patch Set 4 : Fix a line that was too long #

Messages