Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1643493002: Notifications: restrict button icon to 32dp. (Closed)

Created:
4 years, 11 months ago by Michael van Ouwerkerk
Modified:
4 years, 11 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notifications: restrict button icon to 32dp. This size is as recommended in the addAction docs: http://goo.gl/ajjlE0 BUG=581336 Committed: https://crrev.com/2cf1ff1a5efa4ea9cb61165aaf76007fae85942c Cr-Commit-Position: refs/heads/master@{#371828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/android/java/res/layout/web_notification_button.xml View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael van Ouwerkerk
Newton, could you take a look please?
4 years, 11 months ago (2016-01-27 10:18:11 UTC) #3
newt (away)
lgtm
4 years, 11 months ago (2016-01-27 18:24:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643493002/1
4 years, 11 months ago (2016-01-27 18:29:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 18:38:35 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 18:40:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cf1ff1a5efa4ea9cb61165aaf76007fae85942c
Cr-Commit-Position: refs/heads/master@{#371828}

Powered by Google App Engine
This is Rietveld 408576698