Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1643463004: Disable Alt-Svc in Crnet. (Closed)

Created:
4 years, 10 months ago by Bence
Modified:
4 years, 10 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Alt-Svc in Crnet. Alt-Svc is currently disabled in Cronet (in components/cronet/android/*url_request_context_adapter.cc), until this feature is thorougly tested in Chromium. It should also be disabled in Crnet. Committed: https://crrev.com/44f9260b9f9945002138f3bd093a25d3ecafaa3d Cr-Commit-Position: refs/heads/master@{#371903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/crnet/crnet_environment.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Bence
mef: PTAL. I think the cleanest way to address your comments at https://crrev.com/1639913002/#msg11 is to ...
4 years, 10 months ago (2016-01-27 22:11:49 UTC) #2
mef
lgtm
4 years, 10 months ago (2016-01-27 22:36:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643463004/1
4 years, 10 months ago (2016-01-27 22:37:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-27 22:45:40 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 22:47:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44f9260b9f9945002138f3bd093a25d3ecafaa3d
Cr-Commit-Position: refs/heads/master@{#371903}

Powered by Google App Engine
This is Rietveld 408576698