Issue 164341: Ensure we have a valid profile when using...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164341: Ensure we have a valid profile when using... (Closed)

Created:
11 years, 4 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Ensure we have a valid profile when using BrowserInit::LaunchWithProfile::OpenURLsInBrowser() directly and the browser passed in is a popup window. Original Review URL: http://codereview.chromium.org/160331 BUG=http://crbug.com/17520 TEST=see bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23077

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -0 lines)			Patch
M	chrome/browser/browser_init.cc	View	3 chunks	+8 lines, -0 lines	0 comments	Download
A	chrome/browser/browser_init_browsertest.cc	View	1 chunk	+60 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

OK, this is a tweaked test, plus the fix is less aggressive in reusing windows ...

11 years, 4 months ago (2009-08-11 20:34:48 UTC) #1

brettw

Note: split off of http://codereview.chromium.org/160331 To clarify, the different behavior here is that if the ...

11 years, 4 months ago (2009-08-11 20:56:28 UTC) #2

Avi (use Gerrit)

11 years, 4 months ago (2009-08-11 21:21:55 UTC) #3

On 2009/08/11 20:56:28, brettw wrote:
> To clarify, the different behavior here is that if the toplevel window is a
> popup, this will just create a new browser window, while Pink's patch tried to
> find a lower-level one, right?

Correct. Pink's version tried to find a non-popup window to hold a tab, but that
broke popping a new window when double-clicking a shortcut. This should work
well enough for the Mac, and certainly will stop the crash.

Expand Messages | Collapse Messages