Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1643403002: Test and fix a few more corner cases of summarizing type inference. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test and fix a few more corner cases of summarizing type inference. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/8da962e6a39760b10ae2907cec7e92992e11e52d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -12 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 5 chunks +8 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 3 chunks +67 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-01-29 21:43:07 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-01-29 21:46:44 UTC) #3
Paul Berry
4 years, 10 months ago (2016-01-29 21:47:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8da962e6a39760b10ae2907cec7e92992e11e52d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698