Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1643383002: Subzero: Fix a -verbose=regalloc bug. (Closed)

Created:
4 years, 10 months ago by Jim Stichnoth
Modified:
4 years, 10 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix a -verbose=regalloc bug. This is the same as the fix that https://codereview.chromium.org/1531623007 (b19d39cc5fa8dc60c678c2507af02147184f168f) made to the same file. Otherwise the broken x86-32 implementation of getGprForType() gives an assertion failure. BUG= none R=eholk@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=4a659477004e85c491e98311dc5cf0a543ebe547

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/IceRegAlloc.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 10 months ago (2016-01-29 21:16:37 UTC) #3
Eric Holk
lgtm
4 years, 10 months ago (2016-02-01 17:45:43 UTC) #4
Jim Stichnoth
4 years, 10 months ago (2016-02-01 18:41:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4a659477004e85c491e98311dc5cf0a543ebe547 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698