Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1643333002: Adding flag for simd.js + asm->wasm. (Closed)

Created:
4 years, 10 months ago by bradnelson
Modified:
4 years, 10 months ago
Reviewers:
gdeepti, titzer, gdeepti1, bradn
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adding flag for simd.js + asm->wasm. Make it possible to switch on simd.js support when combined with asm.js in the asm->wasm path. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator R=gdeepti@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/4529cb7b6f00b3513f44c9b1dee0b8fd28bb38ab Cr-Commit-Position: refs/heads/master@{#33644}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/flag-definitions.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/typing-asm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-js.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
bradn
4 years, 10 months ago (2016-01-29 20:20:27 UTC) #2
gdeepti1
lgtm
4 years, 10 months ago (2016-01-30 01:09:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643333002/1
4 years, 10 months ago (2016-01-30 01:12:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10332)
4 years, 10 months ago (2016-01-30 01:15:11 UTC) #8
bradn
Need OWNERs review.
4 years, 10 months ago (2016-01-30 01:48:58 UTC) #9
titzer
https://codereview.chromium.org/1643333002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1643333002/diff/1/src/flag-definitions.h#newcode487 src/flag-definitions.h:487: DEFINE_BOOL(asm_thru_wasm_simd, false, "enable SIMD.js for asm->wasm") Flag has a ...
4 years, 10 months ago (2016-02-01 08:04:36 UTC) #10
bradn
ptal https://codereview.chromium.org/1643333002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1643333002/diff/1/src/flag-definitions.h#newcode487 src/flag-definitions.h:487: DEFINE_BOOL(asm_thru_wasm_simd, false, "enable SIMD.js for asm->wasm") On 2016/02/01 ...
4 years, 10 months ago (2016-02-01 17:25:18 UTC) #11
titzer
lgtm
4 years, 10 months ago (2016-02-01 17:53:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643333002/20001
4 years, 10 months ago (2016-02-01 17:54:04 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-01 18:25:24 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 18:25:48 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4529cb7b6f00b3513f44c9b1dee0b8fd28bb38ab
Cr-Commit-Position: refs/heads/master@{#33644}

Powered by Google App Engine
This is Rietveld 408576698