Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 164333010: Re-enable WebNotifications test for linux aura. (Closed)

Created:
6 years, 10 months ago by koss
Modified:
6 years, 10 months ago
Reviewers:
dewittj
CC:
chromium-reviews, tfarina, Elliot Glaysher
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Re-enable WebNotifications test for linux aura. This test is now passing, though with console warnings about IsFullScreenMode not implemented yet for linux and a RENDER WARNING (already noted in http://crbug.com/333003). BUG=163931 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
koss
This is the first patch for re-enabling (a succeeding) WebNotifications test.
6 years, 10 months ago (2014-02-14 20:04:36 UTC) #1
dewittj
On 2014/02/14 20:04:36, koss wrote: > This is the first patch for re-enabling (a succeeding) ...
6 years, 10 months ago (2014-02-14 22:50:55 UTC) #2
dewittj
+erg for real
6 years, 10 months ago (2014-02-14 22:51:08 UTC) #3
koss
The CQ bit was checked by koss@chromium.org
6 years, 10 months ago (2014-02-15 01:34:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koss@chromium.org/164333010/1
6 years, 10 months ago (2014-02-15 01:34:22 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-15 04:10:44 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264975
6 years, 10 months ago (2014-02-15 04:10:44 UTC) #7
koss
The CQ bit was checked by koss@chromium.org
6 years, 10 months ago (2014-02-19 17:05:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koss@chromium.org/164333010/1
6 years, 10 months ago (2014-02-19 17:08:53 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 19:43:25 UTC) #10
Message was sent while issue was closed.
Change committed as 252046

Powered by Google App Engine
This is Rietveld 408576698