Issue 164333008: Make MemoryCache's LRUList manipulation private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164333008: Make MemoryCache's LRUList manipulation private (Closed)

Created:
6 years, 10 months ago by Nate Chapin

Modified:
6 years, 9 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Make MemoryCache's LRUList manipulation private Changes to the LRU lists are hidden behind a call to MemoryCache::update(), which adjusts sizes, access count, and LRU list position as appropriate. All of these are to some degree interrelated, since we keep multiple LRU lists and select one to use based access count and resource size. Also, remove the Resource::inCache() bit in favor of a MemoryCache::contains() BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169748

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -152 lines)			Patch
M	Source/core/fetch/ImageResource.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/fetch/MemoryCache.h	View		5 chunks	+11 lines, -7 lines	0 comments	Download
	Source/core/fetch/MemoryCache.cpp	View	1 2 3 4 5	10 chunks	+43 lines, -49 lines	0 comments	Download
	Source/core/fetch/MemoryCacheTest.cpp	View	1	3 chunks	+8 lines, -11 lines	0 comments	Download
M	Source/core/fetch/Resource.h	View	1	4 chunks	+0 lines, -12 lines	0 comments	Download
	Source/core/fetch/Resource.cpp	View	1 2 3	13 chunks	+24 lines, -67 lines	0 comments	Download
M	Source/core/fetch/ResourceFetcher.cpp	View	1 2 3 4	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/xml/parser/XMLDocumentParser.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/164333008/210001

6 years, 9 months ago (2014-03-21 16:18:10 UTC) #4

Message was sent while issue was closed.

Change committed as 169748

Expand Messages | Collapse Messages