Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 164333003: Revert of Revert of Turn on icu_use_data_file_flag on CrOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 015d44100a0f8b93362eae7f533a1b95e43bde88..16c5abe9727c56c42e40b744ecd983fb4cdbdf3f 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1332,8 +1332,10 @@
# can use breakpad for these builds.
'release_unwind_tables%': 0,
}],
- # TODO(jungshik): Turn this on on Android and Chrome OS
- ['OS!="android" and chromeos==0', {
+ # TODO(jungshik): Turn this on on Android.
+ # For ChromeOS, this should be turned on in chromeos-chrome.ebuild
+ # file as well by adding icu_use_data_file_flag=1 to BUILD_DEFINES.
+ ['OS!="android"', {
'icu_use_data_file_flag%': 1,
}],
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698