Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1643323002: Fix separator to use . for SameVersionStartupCounts suffix. (Closed)

Created:
4 years, 10 months ago by gab
Modified:
4 years, 10 months ago
Reviewers:
jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@a1_startup_count_suffix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix separator to use . for SameVersionStartupCounts suffix. The code already uses ".", forgot to specify in histograms.xml BUG=580211 TBR=jwd@chromium.org Committed: https://crrev.com/6a6abb65393bace69c45c9cc554a96911bec6c6a Cr-Commit-Position: refs/heads/master@{#372439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
gab
Jesse PTAL : shortest review ever?!
4 years, 10 months ago (2016-01-29 19:55:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643323002/1
4 years, 10 months ago (2016-01-29 19:58:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-29 21:27:18 UTC) #6
gab
TBR jwd for the sake of expediency since I want to look at these dashboards ...
4 years, 10 months ago (2016-01-29 22:05:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643323002/1
4 years, 10 months ago (2016-01-29 22:08:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 22:16:35 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 22:17:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a6abb65393bace69c45c9cc554a96911bec6c6a
Cr-Commit-Position: refs/heads/master@{#372439}

Powered by Google App Engine
This is Rietveld 408576698