Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1591)

Unified Diff: Source/core/loader/cache/CachedResourceLoader.cpp

Issue 16433002: Prepopulate the memoryCache with data:uri images. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update TestExpectations Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/cache/CachedResourceLoader.cpp
diff --git a/Source/core/loader/cache/CachedResourceLoader.cpp b/Source/core/loader/cache/CachedResourceLoader.cpp
index d864769b9bb431dd824fb816286399f30fa01821..7a98b8a8eb7fe9f714c6d2732fa13d12653700e0 100644
--- a/Source/core/loader/cache/CachedResourceLoader.cpp
+++ b/Source/core/loader/cache/CachedResourceLoader.cpp
@@ -50,6 +50,7 @@
#include "core/loader/cache/CachedResourceRequest.h"
#include "core/loader/cache/CachedScript.h"
#include "core/loader/cache/CachedShader.h"
+#include "core/loader/cache/CachedTextTrack.h"
#include "core/loader/cache/CachedXSLStyleSheet.h"
#include "core/loader/cache/MemoryCache.h"
#include "core/page/Console.h"
@@ -59,16 +60,16 @@
#include "core/page/Performance.h"
#include "core/page/Settings.h"
#include "core/platform/Logging.h"
+#include "public/platform/Platform.h"
+#include "public/platform/WebURL.h"
#include "weborigin/SecurityOrigin.h"
#include "weborigin/SecurityPolicy.h"
-#include "core/loader/cache/CachedTextTrack.h"
-
#define PRELOAD_DEBUG 0
namespace WebCore {
-static CachedResource* createResource(CachedResource::Type type, ResourceRequest& request, const String& charset)
+static CachedResource* createResource(CachedResource::Type type, const ResourceRequest& request, const String& charset)
{
switch (type) {
case CachedResource::ImageResource:
@@ -132,6 +133,27 @@ static ResourceLoadPriority loadPriority(CachedResource::Type type, const Cached
return ResourceLoadPriorityUnresolved;
}
+static CachedResource* resourceFromDataURIRequest(const ResourceRequest& request)
+{
+ const KURL& url = request.url();
+ ASSERT(url.protocolIsData());
+
+ WebKit::WebString mimetype;
+ WebKit::WebString charset;
+ RefPtr<SharedBuffer> data = PassRefPtr<SharedBuffer>(WebKit::Platform::current()->parseDataURL(url, mimetype, charset));
+ if (!data)
+ return 0;
+ ResourceResponse response(url, mimetype, data->size(), charset, String());
+
+ CachedResource* resource = createResource(CachedResource::ImageResource, request, charset);
+ resource->responseReceived(response);
+ // FIXME: AppendData causes an unnecessary memcpy.
+ if (data->size())
+ resource->appendData(data->data(), data->size());
+ resource->finish();
+ return resource;
+}
+
CachedResourceLoader::CachedResourceLoader(DocumentLoader* documentLoader)
: m_document(0)
, m_documentLoader(documentLoader)
@@ -181,10 +203,26 @@ CachedResourceHandle<CachedImage> CachedResourceLoader::requestImage(CachedResou
return 0;
}
}
+
+ if (request.resourceRequest().url().protocolIsData())
+ preCacheDataURIImage(request);
+
request.setDefer(clientDefersImage(request.resourceRequest().url()) ? CachedResourceRequest::DeferredByClient : CachedResourceRequest::NoDefer);
return static_cast<CachedImage*>(requestResource(CachedResource::ImageResource, request).get());
}
+void CachedResourceLoader::preCacheDataURIImage(const CachedResourceRequest& request)
+{
+ const KURL& url = request.resourceRequest().url();
+ ASSERT(url.protocolIsData());
+
+ if (CachedResource* existing = memoryCache()->resourceForURL(url))
+ return;
abarth-chromium 2013/06/09 05:57:39 Ok, this variation makes sense too.
+
+ if (CachedResource* resource = resourceFromDataURIRequest(request.resourceRequest()))
+ memoryCache()->add(resource);
+}
+
CachedResourceHandle<CachedFont> CachedResourceLoader::requestFont(CachedResourceRequest& request)
{
return static_cast<CachedFont*>(requestResource(CachedResource::FontResource, request).get());
@@ -664,6 +702,11 @@ CachedResourceLoader::RevalidationPolicy CachedResourceLoader::determineRevalida
return Reload;
}
+ // Always use data uris.
+ // FIXME: Extend this to non-images.
+ if (type == CachedResource::ImageResource && request.url().protocolIsData())
+ return Use;
+
if (!existingResource->canReuse(request))
return Reload;

Powered by Google App Engine
This is Rietveld 408576698