BrowserGpuMemoryBufferManager::IsNativeGpuMemoryBuffersEnabled() return true if at least one native…

BrowserGpuMemoryBufferManager::IsNativeGpuMemoryBuffersEnabled() return true if at least one native format is supported.

BUG=475633

[dshwang, 2016-01-29 18:41:07]

Description was changed from

==========
BrowserGpuMemoryBufferManager::IsNativeGpuMemoryBuffersEnabled() return true if
at least one native format is supported.

BUG=475633
==========

to

==========
BrowserGpuMemoryBufferManager::IsNativeGpuMemoryBuffersEnabled() return true if
at least one native format is supported.

BUG=475633
==========

[dshwang, 2016-01-29 18:41:07]

dongseong.hwang@intel.com changed reviewers:
+ reveman@chromium.org

[dshwang, 2016-01-29 18:44:42]

reveman, could you review?
It spin off from https://codereview.chromium.org/1637423004/

I think it's good for kEnableGpuMemoryBufferCompositorResources also.
It's not good to enable GpuMemoryBufferCompositorResources if at least one
native format isn't supported.
In the case, any GpuMemoryBuffers aren't backed on actual GL Image.
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/gp...

[inactive_dshwang_plz_cc_intel, 2016-01-29 18:44:55]

The CQ bit was checked by dongseong.hwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 18:45:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1643293002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1643293002/1

[dshwang, 2016-01-29 18:52:45]

dongseong.hwang@intel.com changed reviewers:
+ ccameron@chromium.org

[dshwang, 2016-01-29 18:54:37]

ccameron, could you review the change of
IsGpuMemoryBufferCompositorResourcesEnabled(), which was implemented in your CL;
https://codereview.chromium.org/1421293006/

[reveman, 2016-01-29 19:27:12]

https://codereview.chromium.org/1643293002/diff/1/content/browser/gpu/browser...
File content/browser/gpu/browser_gpu_memory_buffer_manager.cc (right):

https://codereview.chromium.org/1643293002/diff/1/content/browser/gpu/browser...
content/browser/gpu/browser_gpu_memory_buffer_manager.cc:215: };
This represents the value of the command line flags in combination with what's
default on the platform. I'd rather not change that.

[dshwang, 2016-01-29 19:35:26]

https://codereview.chromium.org/1643293002/diff/1/content/browser/gpu/browser...
File content/browser/gpu/browser_gpu_memory_buffer_manager.cc (right):

https://codereview.chromium.org/1643293002/diff/1/content/browser/gpu/browser...
content/browser/gpu/browser_gpu_memory_buffer_manager.cc:215: };
On 2016/01/29 19:27:12, reveman wrote:
> This represents the value of the command line flags in combination with what's
> default on the platform. I'd rather not change that.

It's not changed.
This CL change only behavior of
BrowserGpuMemoryBufferManager::IsNativeGpuMemoryBuffersEnabled().

[reveman, 2016-01-29 19:38:11]

https://codereview.chromium.org/1643293002/diff/1/content/browser/gpu/browser...
File content/browser/gpu/browser_gpu_memory_buffer_manager.cc (right):

https://codereview.chromium.org/1643293002/diff/1/content/browser/gpu/browser...
content/browser/gpu/browser_gpu_memory_buffer_manager.cc:215: };
On 2016/01/29 at 19:35:26, dshwang wrote:
> On 2016/01/29 19:27:12, reveman wrote:
> > This represents the value of the command line flags in combination with
what's
> > default on the platform. I'd rather not change that.

hm, not sure how this comment ended up here. I was trying to comment on
IsNativeGpuMemoryBuffersEnabled().

> 
> It's not changed.
> This CL change only behavior of
BrowserGpuMemoryBufferManager::IsNativeGpuMemoryBuffersEnabled().

Yes, that's what my comment was supposed to be about. I don't think we should
change BrowserGpuMemoryBufferManager::IsNativeGpuMemoryBuffersEnabled().

[dshwang, 2016-01-29 19:39:29]

On 2016/01/29 19:38:11, reveman wrote:
>
https://codereview.chromium.org/1643293002/diff/1/content/browser/gpu/browser...
> File content/browser/gpu/browser_gpu_memory_buffer_manager.cc (right):
> 
>
https://codereview.chromium.org/1643293002/diff/1/content/browser/gpu/browser...
> content/browser/gpu/browser_gpu_memory_buffer_manager.cc:215: };
> On 2016/01/29 at 19:35:26, dshwang wrote:
> > On 2016/01/29 19:27:12, reveman wrote:
> > > This represents the value of the command line flags in combination with
> what's
> > > default on the platform. I'd rather not change that.
> 
> hm, not sure how this comment ended up here. I was trying to comment on
> IsNativeGpuMemoryBuffersEnabled().
> 
> > 
> > It's not changed.
> > This CL change only behavior of
> BrowserGpuMemoryBufferManager::IsNativeGpuMemoryBuffersEnabled().
> 
> Yes, that's what my comment was supposed to be about. I don't think we should
> change BrowserGpuMemoryBufferManager::IsNativeGpuMemoryBuffersEnabled().

got it. I close it as WontFix. Thank you