Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 1643253002: Make constant map literal ordered. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make constant map literal ordered. Plus couple fixes for spelling problems. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2546e179a9b239c8b237f81fa0433fff434da8b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/constant_test.dart View 5 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-01-29 17:05:35 UTC) #1
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-01-29 17:23:12 UTC) #2
scheglov
4 years, 10 months ago (2016-01-29 17:31:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2546e179a9b239c8b237f81fa0433fff434da8b8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698