Issue 164318: Added regression test for event listeners memory leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164318: Added regression test for event listeners memory leak. (Closed)

Created:
11 years, 4 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Added regression test for event listeners memory leak. BUG=17400

Patch Set 1 #

Patch Set 2 : patch #

Patch Set 3 : Use V8 log to count live objects. #

Patch Set 4 : Removed some unused includes. #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -5 lines)			Patch
A	webkit/data/listener/listener_leak1.html	View	1 2	1 chunk	+37 lines, -0 lines	0 comments	Download
A	webkit/data/listener/listener_leak2.html	View	1 2	1 chunk	+39 lines, -0 lines	0 comments	Download
A	webkit/tools/test_shell/listener_leak_test.cc	View	1 2 3	1 chunk	+78 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/node_leak_test.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	webkit/tools/test_shell/run_all_tests.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

Mike, Could you please have a look at this? Darin recommended you as a reviewer. ...

11 years, 4 months ago (2009-08-11 18:46:36 UTC) #2

Mike Belshe

11 years, 4 months ago (2009-08-11 18:58:38 UTC) #3

LGTM

On 2009/08/11 18:46:36, Vitaly wrote:
> Mike,
> 
> Could you please have a look at this? Darin recommended you as a reviewer.
> 
> (Note, I'm not a Chromium committer yet, I can't land the patch.)
> 
> Thanks,
> Vitaly

Expand Messages | Collapse Messages