Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 164313005: [Hotword] Updating the helper extension to listen to the speech reset message from the main extensi… (Closed)

Created:
6 years, 10 months ago by rpetterson
Modified:
6 years, 10 months ago
Reviewers:
dou1, James Hawkins
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

[Hotword] Updating the helper extension to listen to the speech reset message from the main extension. BUG=325439, 289023 TBR=jhawkins@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251487

Patch Set 1 #

Patch Set 2 : trying upload again #

Patch Set 3 : 3rd times a charm #

Patch Set 4 : or not #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/hotword_helper/audio_client.js View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
rpetterson
dou to make sure I updated the extension correctly. jhawkins for owners approval in browser/resources
6 years, 10 months ago (2014-02-13 22:19:01 UTC) #1
dou1
On 2014/02/13 22:19:01, rpetterson wrote: > dou to make sure I updated the extension correctly. ...
6 years, 10 months ago (2014-02-13 22:21:25 UTC) #2
rpetterson
moving jhawkins to TBR since it's a small change.
6 years, 10 months ago (2014-02-14 21:47:11 UTC) #3
rpetterson
The CQ bit was checked by rlp@chromium.org
6 years, 10 months ago (2014-02-14 21:47:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/164313005/70001
6 years, 10 months ago (2014-02-14 21:51:26 UTC) #5
James Hawkins
lgtm
6 years, 10 months ago (2014-02-14 22:25:04 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-15 00:34:41 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264745
6 years, 10 months ago (2014-02-15 00:34:42 UTC) #8
rpetterson
The CQ bit was checked by rlp@chromium.org
6 years, 10 months ago (2014-02-15 00:35:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/164313005/70001
6 years, 10 months ago (2014-02-15 00:57:50 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 03:12:21 UTC) #11
Message was sent while issue was closed.
Change committed as 251487

Powered by Google App Engine
This is Rietveld 408576698