Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 164313002: Rename ServiceConnector back to ServiceManager (Closed)

Created:
6 years, 10 months ago by DaveMoore
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Rename ServiceConnector back to ServiceManager BUG=None TEST=None TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251111

Patch Set 1 #

Patch Set 2 : Bad upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -379 lines) Patch
M mojo/mojo.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/android/mojo_main.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/context.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/dynamic_service_loader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/run.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D mojo/shell/service_connector.h View 1 chunk +0 lines, -74 lines 0 comments Download
D mojo/shell/service_connector.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D mojo/shell/service_connector_unittest.cc View 1 chunk +0 lines, -138 lines 0 comments Download
A + mojo/shell/service_manager.h View 4 chunks +10 lines, -10 lines 0 comments Download
A + mojo/shell/service_manager.cc View 6 chunks +19 lines, -19 lines 0 comments Download
A + mojo/shell/service_manager_unittest.cc View 4 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
DaveMoore
Bad upload
6 years, 10 months ago (2014-02-13 19:07:53 UTC) #1
DaveMoore
The CQ bit was checked by davemoore@chromium.org
6 years, 10 months ago (2014-02-13 19:09:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/164313002/110001
6 years, 10 months ago (2014-02-13 19:11:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/164313002/110001
6 years, 10 months ago (2014-02-13 20:02:01 UTC) #4
DaveMoore
6 years, 10 months ago (2014-02-13 20:22:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r251111 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698