Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1643123003: V4L2SVDA: Move allocation from GPU Child thread to decoder thread. (Closed)

Created:
4 years, 10 months ago by Pawel Osciak
Modified:
4 years, 10 months ago
Reviewers:
wuchengli
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

V4L2SVDA: Move allocation from GPU Child thread to decoder thread. Allocation may take time, and we don't need to be on the GPU Child thread to do it. This also removes the explicit synchronization between the decoder and GPU Child threads during picture set change. BUG=574241 TEST=vdatest,crosvideo.appspot Committed: https://crrev.com/6b8b26b67eeedd5fd40a3a2ca027a734cca4f218 Cr-Commit-Position: refs/heads/master@{#376120}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -104 lines) Patch
M content/common/gpu/media/v4l2_slice_video_decode_accelerator.h View 1 3 chunks +38 lines, -21 lines 0 comments Download
M content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc View 1 15 chunks +130 lines, -83 lines 2 comments Download

Messages

Total messages: 12 (5 generated)
Pawel Osciak
4 years, 10 months ago (2016-01-29 05:32:09 UTC) #3
Pawel Osciak
PTAL. PostProcessPendingEvents() not needed/used anymore.
4 years, 10 months ago (2016-02-15 01:24:48 UTC) #4
wuchengli
lgtm
4 years, 10 months ago (2016-02-18 08:03:51 UTC) #5
wuchengli
https://codereview.chromium.org/1643123003/diff/20001/content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc File content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc (right): https://codereview.chromium.org/1643123003/diff/20001/content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc#newcode979 content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc:979: ScheduleDecodeBufferTaskIfNeeded(); I asked offline about why we need line ...
4 years, 10 months ago (2016-02-18 08:06:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643123003/20001
4 years, 10 months ago (2016-02-18 08:07:02 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-18 08:45:58 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 08:47:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b8b26b67eeedd5fd40a3a2ca027a734cca4f218
Cr-Commit-Position: refs/heads/master@{#376120}

Powered by Google App Engine
This is Rietveld 408576698