Issue 164312: Make the theme install infobar have an 'undo' button instead of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164312: Make the theme install infobar have an 'undo' button instead of (Closed)

Created:
11 years, 4 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make the theme install infobar have an 'undo' button instead of a 'back to default' button. BUG=18986 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23055

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -18 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+2 lines, -2 lines	1 comment	Download
M	chrome/browser/extensions/extension_install_ui.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.cc	View	3 chunks	+8 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/theme_preview_infobar_delegate.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/theme_preview_infobar_delegate.cc	View	2 chunks	+17 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Glen Murphy

11 years, 4 months ago (2009-08-11 17:01:56 UTC) #2

LG, with string complications:

http://codereview.chromium.org/164312/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/164312/diff/1/2#newcode2083
Line 2083: Undo
String freeze was a few weeks ago; I know it's a hack, but if we want this patch
for stable, can we use IDS_UNDO (or any of the others) instead?

Expand Messages | Collapse Messages