chrome/browser/validation_message_message_filter.cc - Issue 16431010: Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/validation_message_message_filter.cc

Issue 16431010: Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase on top of hash_pair move. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc ('k') | content/browser/accessibility/accessibility_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/validation_message_message_filter.cc

diff --git a/chrome/browser/validation_message_message_filter.cc b/chrome/browser/validation_message_message_filter.cc

index 1d48232fb5648748444c58d58b41fffff4d45d01..ef2366bed06d108c9ac8266f0fa69cc3cf8239c4 100644

--- a/chrome/browser/validation_message_message_filter.cc

+++ b/chrome/browser/validation_message_message_filter.cc

@@ -62,8 +62,8 @@ void ValidationMessageMessageFilter::OverrideThreadForMessage(

void ValidationMessageMessageFilter::OnShowValidationMessage(

int route_id, const gfx::Rect& anchor_in_root_view,

const string16& main_text, const string16& sub_text) {

- RenderProcessHost* process = RenderProcessHost::FromID(renderer_id_);

- RenderWidgetHost* widget_host = process->GetRenderWidgetHostByID(route_id);

+ RenderWidgetHost* widget_host =

+ RenderWidgetHost::FromID(renderer_id_, route_id);

validation_message_bubble_ = chrome::ValidationMessageBubble::CreateAndShow(

widget_host, anchor_in_root_view, main_text, sub_text);

}

@@ -76,8 +76,8 @@ void ValidationMessageMessageFilter::OnMoveValidationMessage(

int route_id, const gfx::Rect& anchor_in_root_view) {

if (!validation_message_bubble_)

return;

- RenderProcessHost* process = RenderProcessHost::FromID(renderer_id_);

- RenderWidgetHost* widget_host = process->GetRenderWidgetHostByID(route_id);

+ RenderWidgetHost* widget_host =

+ RenderWidgetHost::FromID(renderer_id_, route_id);

validation_message_bubble_->SetPositionRelativeToAnchor(

widget_host, anchor_in_root_view);

}