Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Unified Diff: chrome/browser/performance_monitor/performance_monitor.cc

Issue 16431010: Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase on top of hash_pair move. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/performance_monitor/performance_monitor.cc
diff --git a/chrome/browser/performance_monitor/performance_monitor.cc b/chrome/browser/performance_monitor/performance_monitor.cc
index 643c4c1cca07733275803df8da491aa0e06c7658..4143f123444002008c8ba414ab515be3c8092593 100644
--- a/chrome/browser/performance_monitor/performance_monitor.cc
+++ b/chrome/browser/performance_monitor/performance_monitor.cc
@@ -618,23 +618,19 @@ void PerformanceMonitor::AddRendererClosedEvent(
details.status == base::TERMINATION_STATUS_PROCESS_WAS_KILLED ?
EVENT_RENDERER_KILLED : EVENT_RENDERER_CRASH;
- content::RenderProcessHost::RenderWidgetHostsIterator iter =
- host->GetRenderWidgetHostsIterator();
-
// A RenderProcessHost may contain multiple render views - for each valid
// render view, extract the url, and append it to the string, comma-separating
// the entries.
std::string url_list;
- for (; !iter.IsAtEnd(); iter.Advance()) {
- const content::RenderWidgetHost* widget = iter.GetCurrentValue();
- DCHECK(widget);
- if (!widget || !widget->IsRenderView())
+ content::RenderWidgetHost::List widgets =
+ content::RenderWidgetHost::GetRenderWidgetHosts();
+ for (size_t i = 0; i < widgets.size(); ++i) {
+ if (widgets[i]->GetProcess()->GetID() != host->GetID())
+ continue;
+ if (!widgets[i]->IsRenderView())
continue;
- content::RenderViewHost* view =
- content::RenderViewHost::From(
- const_cast<content::RenderWidgetHost*>(widget));
-
+ content::RenderViewHost* view = content::RenderViewHost::From(widgets[i]);
std::string url;
if (!MaybeGetURLFromRenderView(view, &url))
continue;
« no previous file with comments | « chrome/browser/memory_details.cc ('k') | chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698