Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: content/public/test/mock_render_process_host.cc

Issue 16431010: Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix cleanup crashes. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/mock_render_process_host.cc
diff --git a/content/public/test/mock_render_process_host.cc b/content/public/test/mock_render_process_host.cc
index 8d25ba223d402c4569ca4234ee5591793b64e100..d2662347b80d9903a75d655304e692bcf10612b7 100644
--- a/content/public/test/mock_render_process_host.cc
+++ b/content/public/test/mock_render_process_host.cc
@@ -53,6 +53,18 @@ int MockRenderProcessHost::GetNextRoutingID() {
return ++prev_routing_id;
}
+void MockRenderProcessHost::AddRoute(
+ int32 routing_id,
+ IPC::Listener* listener) {
+ listeners_.AddWithID(listener, routing_id);
+}
+
+void MockRenderProcessHost::RemoveRoute(int32 routing_id) {
+ DCHECK(listeners_.Lookup(routing_id) != NULL);
+ listeners_.Remove(routing_id);
+ Cleanup();
+}
+
void MockRenderProcessHost::SimulateSwapOutACK(
const ViewMsg_SwapOut_Params& params) {
}
@@ -157,18 +169,8 @@ bool MockRenderProcessHost::IgnoreInputEvents() const {
return false;
}
-void MockRenderProcessHost::Attach(RenderWidgetHost* host,
- int routing_id) {
- render_widget_hosts_.AddWithID(host, routing_id);
-}
-
-void MockRenderProcessHost::Release(int routing_id) {
- render_widget_hosts_.Remove(routing_id);
- Cleanup();
-}
-
void MockRenderProcessHost::Cleanup() {
- if (render_widget_hosts_.IsEmpty()) {
+ if (listeners_.IsEmpty()) {
NotificationService::current()->Notify(
NOTIFICATION_RENDERER_PROCESS_TERMINATED,
Source<RenderProcessHost>(this),
@@ -191,11 +193,6 @@ bool MockRenderProcessHost::SuddenTerminationAllowed() const {
return true;
}
-RenderWidgetHost* MockRenderProcessHost::GetRenderWidgetHostByID(
- int routing_id) {
- return render_widget_hosts_.Lookup(routing_id);
-}
-
BrowserContext* MockRenderProcessHost::GetBrowserContext() const {
return browser_context_;
}
@@ -211,7 +208,7 @@ IPC::ChannelProxy* MockRenderProcessHost::GetChannel() {
}
bool MockRenderProcessHost::FastShutdownForPageCount(size_t count) {
- if (render_widget_hosts_.size() == count)
+ if (listeners_.size() == count)
return FastShutdownIfPossible();
return false;
}
@@ -226,15 +223,11 @@ void MockRenderProcessHost::SurfaceUpdated(int32 surface_id) {
void MockRenderProcessHost::ResumeRequestsForView(int route_id) {
}
-RenderProcessHost::RenderWidgetHostsIterator
- MockRenderProcessHost::GetRenderWidgetHostsIterator() {
- return RenderWidgetHostsIterator(&render_widget_hosts_);
-}
bool MockRenderProcessHost::OnMessageReceived(const IPC::Message& msg) {
- RenderWidgetHost* rwh = render_widget_hosts_.Lookup(msg.routing_id());
- if (rwh)
- return RenderWidgetHostImpl::From(rwh)->OnMessageReceived(msg);
+ IPC::Listener* listener = listeners_.Lookup(msg.routing_id());
+ if (listener)
+ return listener->OnMessageReceived(msg);
return false;
}
« content/public/browser/render_widget_host.h ('K') | « content/public/test/mock_render_process_host.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698