Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: content/public/browser/render_process_host.h

Issue 16431010: Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix cleanup crashes. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/render_process_host.h
diff --git a/content/public/browser/render_process_host.h b/content/public/browser/render_process_host.h
index da1bc3458b4149f0905f04ee750c0ae6ad1c00c7..18ed0afe5cb9f98197302c7b64b6c73c56289818 100644
--- a/content/public/browser/render_process_host.h
+++ b/content/public/browser/render_process_host.h
@@ -37,7 +37,6 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
public IPC::Listener {
public:
typedef IDMap<RenderProcessHost>::iterator iterator;
- typedef IDMap<RenderWidgetHost>::const_iterator RenderWidgetHostsIterator;
// Details for RENDERER_PROCESS_CLOSED notifications.
struct RendererClosedDetails {
@@ -64,6 +63,10 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
// Gets the next available routing id.
virtual int GetNextRoutingID() = 0;
+ // These methods add or remove listener for a specific message routing ID.
+ virtual void AddRoute(int32 routing_id, IPC::Listener* listener) = 0;
+ virtual void RemoveRoute(int32 routing_id) = 0;
+
// Called on the UI thread to simulate a SwapOut_ACK message to the
// ResourceDispatcherHost. Necessary for a cross-site request, in the case
// that the original RenderViewHost is not live and thus cannot run an
@@ -146,9 +149,6 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
// etc.
virtual int GetID() const = 0;
- // Returns the render widget host for the routing id passed in.
- virtual RenderWidgetHost* GetRenderWidgetHostByID(int routing_id) = 0;
-
// Returns true iff channel_ has been set to non-NULL. Use this for checking
// if there is connection or not. Virtual for mocking out for tests.
virtual bool HasConnection() const = 0;
@@ -160,9 +160,6 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
// Returns the renderer channel.
virtual IPC::ChannelProxy* GetChannel() = 0;
- // Returns the list of attached render widget hosts.
- virtual RenderWidgetHostsIterator GetRenderWidgetHostsIterator() = 0;
-
// Try to shutdown the associated render process as fast as possible
virtual bool FastShutdownForPageCount(size_t count) = 0;
@@ -175,10 +172,10 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
// Used for refcounting, each holder of this object must Attach and Release
// just like it would for a COM object. This object should be allocated on
// the heap; when no listeners own it any more, it will delete itself.
- virtual void Attach(content::RenderWidgetHost* host, int routing_id) = 0;
+ // virtual void Attach(content::RenderWidgetHost* host, int routing_id) = 0;
// See Attach()
- virtual void Release(int routing_id) = 0;
+ // virtual void Release(int routing_id) = 0;
// Schedules the host for deletion and removes it from the all_hosts list.
virtual void Cleanup() = 0;

Powered by Google App Engine
This is Rietveld 408576698