chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc - Issue 16431010: Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc

Issue 16431010: Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix cleanup crashes. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_manager/guest_resource_provider.cc ('k') | chrome/browser/validation_message_message_filter.cc » ('j') | content/browser/devtools/render_view_devtools_agent_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc

diff --git a/chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc b/chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc

index 4a8eac83479083cb8059ec9c029047814f80c6b1..dd596caf84b57181c03b89e8e78828454e11953e 100644

--- a/chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc

+++ b/chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc

@@ -137,9 +137,9 @@ void ChromeWebContentsViewDelegateGtk::ShowContextMenu(

content::RenderWidgetHostView* view = NULL;

if (params.custom_context.render_widget_id !=

content::CustomContextMenuContext::kCurrentRenderWidget) {

- content::RenderWidgetHost* host =

- web_contents_->GetRenderProcessHost()->GetRenderWidgetHostByID(

- params.custom_context.render_widget_id);

+ content::RenderWidgetHost* host = content::RenderWidgetHost::FromID(

+ web_contents_->GetRenderProcessHost()->GetID(),

+ params.custom_context.render_widget_id);

if (!host) {

NOTREACHED();

return;