Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1360)

Unified Diff: chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

Issue 16431010: Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix cleanup crashes. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
diff --git a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
index d92ec09170c4c660adf2e8e406b9ac2d7fc470de..b5ce73ea8531812ae62b23eeb6d13411c4dd3879 100644
--- a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
+++ b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
@@ -36,28 +36,25 @@ int RenderProcessHostCount() {
}
RenderViewHost* FindFirstDevToolsHost() {
- content::RenderProcessHost::iterator hosts =
- content::RenderProcessHost::AllHostsIterator();
- for (; !hosts.IsAtEnd(); hosts.Advance()) {
- content::RenderProcessHost* render_process_host = hosts.GetCurrentValue();
- DCHECK(render_process_host);
- if (!render_process_host->HasConnection())
+
+ scoped_ptr<RenderWidgetHost::List> hosts =
+ RenderWidgetHost::GetRenderWidgetHosts();
+ for (RenderWidgetHost::List::const_iterator it = hosts->begin();
+ it != hosts->end();
+ ++it) {
+ const RenderWidgetHost* widget = *it;
+ if (!widget->GetProcess()->HasConnection())
continue;
- content::RenderProcessHost::RenderWidgetHostsIterator iter(
- render_process_host->GetRenderWidgetHostsIterator());
- for (; !iter.IsAtEnd(); iter.Advance()) {
- const RenderWidgetHost* widget = iter.GetCurrentValue();
- DCHECK(widget);
- if (!widget || !widget->IsRenderView())
- continue;
- RenderViewHost* host =
- RenderViewHost::From(const_cast<RenderWidgetHost*>(widget));
- WebContents* contents = WebContents::FromRenderViewHost(host);
- GURL url = contents->GetURL();
- if (url.SchemeIs(chrome::kChromeDevToolsScheme))
- return host;
- }
+ if (!widget->IsRenderView())
+ continue;
+ RenderViewHost* host =
+ RenderViewHost::From(const_cast<RenderWidgetHost*>(widget));
+ WebContents* contents = WebContents::FromRenderViewHost(host);
+ GURL url = contents->GetURL();
+ if (url.SchemeIs(chrome::kChromeDevToolsScheme))
+ return host;
}
+
return NULL;
}

Powered by Google App Engine
This is Rietveld 408576698