Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: content/browser/accessibility/browser_accessibility_state_impl.cc

Issue 16431010: Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing Windows compile error. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_state_impl.cc
diff --git a/content/browser/accessibility/browser_accessibility_state_impl.cc b/content/browser/accessibility/browser_accessibility_state_impl.cc
index 92bc94e3839fa5209fb1d807951bbe4c38af2d69..b66d0468b7d199b470ae2018c2b3232a5c39a27a 100644
--- a/content/browser/accessibility/browser_accessibility_state_impl.cc
+++ b/content/browser/accessibility/browser_accessibility_state_impl.cc
@@ -128,27 +128,20 @@ void BrowserAccessibilityStateImpl::SetAccessibilityMode(
if (accessibility_mode_ == mode)
return;
accessibility_mode_ = mode;
- for (RenderProcessHost::iterator it(RenderProcessHost::AllHostsIterator());
- !it.IsAtEnd(); it.Advance()) {
- RenderProcessHost* render_process_host = it.GetCurrentValue();
- DCHECK(render_process_host);
+ RenderWidgetHost::List widgets = RenderWidgetHost::GetRenderWidgetHosts();
+ for (RenderWidgetHost::List::const_iterator it = widgets.begin();
jam 2013/06/12 19:59:59 ditto
nasko 2013/06/12 21:18:59 Done.
+ it != widgets.end(); ++it) {
+ const RenderWidgetHost* widget = *it;
// Ignore processes that don't have a connection, such as crashed tabs.
- if (!render_process_host->HasConnection())
+ if (!widget->GetProcess()->HasConnection())
+ continue;
+ if (!widget->IsRenderView())
continue;
- for (RenderProcessHost::RenderWidgetHostsIterator rwit(
- render_process_host->GetRenderWidgetHostsIterator());
- !rwit.IsAtEnd();
- rwit.Advance()) {
- RenderWidgetHost* rwh = const_cast<RenderWidgetHost*>(
- rwit.GetCurrentValue());
- DCHECK(rwh);
- if (!rwh || !rwh->IsRenderView())
- continue;
- RenderWidgetHostImpl* rwhi = RenderWidgetHostImpl::From(rwh);
- rwhi->SetAccessibilityMode(mode);
- }
+ RenderWidgetHostImpl* rwhi =
+ RenderWidgetHostImpl::From(const_cast<RenderWidgetHost*>(widget));
jam 2013/06/12 19:59:59 you'd get rid of the const cast after switching to
nasko 2013/06/12 21:18:59 Done.
+ rwhi->SetAccessibilityMode(mode);
}
}

Powered by Google App Engine
This is Rietveld 408576698