Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: chrome/browser/task_manager/guest_resource_provider.cc

Issue 16431010: Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing Windows compile error. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/guest_resource_provider.cc
diff --git a/chrome/browser/task_manager/guest_resource_provider.cc b/chrome/browser/task_manager/guest_resource_provider.cc
index 5e17851fc1848ac1521ffe82db5b3b26e908542b..7a9a9b71451b273da5fa0e521963151e67afabc5 100644
--- a/chrome/browser/task_manager/guest_resource_provider.cc
+++ b/chrome/browser/task_manager/guest_resource_provider.cc
@@ -132,19 +132,15 @@ void GuestResourceProvider::StartUpdating() {
updating_ = true;
// Add all the existing guest WebContents.
- for (RenderProcessHost::iterator i(
- RenderProcessHost::AllHostsIterator());
- !i.IsAtEnd(); i.Advance()) {
- RenderProcessHost::RenderWidgetHostsIterator iter =
- i.GetCurrentValue()->GetRenderWidgetHostsIterator();
- for (; !iter.IsAtEnd(); iter.Advance()) {
- const RenderWidgetHost* widget = iter.GetCurrentValue();
- if (widget->IsRenderView()) {
- RenderViewHost* rvh =
- RenderViewHost::From(const_cast<RenderWidgetHost*>(widget));
- if (rvh->IsSubframe())
- Add(rvh);
- }
+ RenderWidgetHost::List widgets = RenderWidgetHost::GetRenderWidgetHosts();
+ for (RenderWidgetHost::List::const_iterator it = widgets.begin();
jam 2013/06/12 19:59:59 ditto
nasko 2013/06/12 21:18:59 Done.
+ it != widgets.end(); ++it) {
+ const RenderWidgetHost* widget = *it;
+ if (widget->IsRenderView()) {
+ RenderViewHost* rvh =
+ RenderViewHost::From(const_cast<RenderWidgetHost*>(widget));
+ if (rvh->IsSubframe())
+ Add(rvh);
}
}

Powered by Google App Engine
This is Rietveld 408576698