Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: chrome/browser/extensions/api/processes/processes_api.cc

Issue 16431010: Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing Windows compile error. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/processes/processes_api.cc
diff --git a/chrome/browser/extensions/api/processes/processes_api.cc b/chrome/browser/extensions/api/processes/processes_api.cc
index adcd39d35906070441286cecf4ca5d82dfd705dc..628c729c0e7c34a26e46e149b9278f1d6ce970a2 100644
--- a/chrome/browser/extensions/api/processes/processes_api.cc
+++ b/chrome/browser/extensions/api/processes/processes_api.cc
@@ -112,12 +112,14 @@ ListValue* GetTabsForProcess(int process_id) {
int tab_id = -1;
// We need to loop through all the RVHs to ensure we collect the set of all
// tabs using this renderer process.
- content::RenderProcessHost::RenderWidgetHostsIterator iter(
- rph->GetRenderWidgetHostsIterator());
- for (; !iter.IsAtEnd(); iter.Advance()) {
- const content::RenderWidgetHost* widget = iter.GetCurrentValue();
- DCHECK(widget);
- if (!widget || !widget->IsRenderView())
+ content::RenderWidgetHost::List widgets =
+ content::RenderWidgetHost::GetRenderWidgetHosts();
+ for (content::RenderWidgetHost::List::const_iterator it = widgets.begin();
jam 2013/06/12 19:59:59 ditto
nasko 2013/06/12 21:18:59 Done.
+ it != widgets.end(); ++it) {
+ const content::RenderWidgetHost* widget = *it;
+ if (widget->GetProcess()->GetID() != process_id)
+ continue;
+ if (!widget->IsRenderView())
continue;
content::RenderViewHost* host = content::RenderViewHost::From(

Powered by Google App Engine
This is Rietveld 408576698