Issue 164310: Mac: Make the password-field capslock indicator work again....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164310: Mac: Make the password-field capslock indicator work again.... (Closed)

Created:
11 years, 4 months ago by viettrungluu-gmail

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Mac: Make the password-field capslock indicator work again. Since we DCHECK() that the event should be some sort of key-up or down (now raw, which was the problem), there's no particular reason to check for the type, is there? (Fix required pointed out by hbono.) BUG=18807 TEST=Go to web page with password field (e.g., gmail login) and select it; cycle capslock.

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	webkit/glue/webview_impl.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu-gmail

Sure, please. avi@chromium.org wrote: > LG. > > Do you want me to land this? ...

11 years, 4 months ago (2009-08-11 14:23:50 UTC) #2

Landed, r23024.

Expand Messages | Collapse Messages