Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1643063002: Revert of Handle pointer-events: none in browser process hittesting. (Closed)

Created:
4 years, 10 months ago by Charlie Reis
Modified:
4 years, 10 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Handle pointer-events: none in browser process hittesting. (patchset #23 id:460001 of https://codereview.chromium.org/1489913003/ ) Reason for revert: Led to a large spike in renderer crashes in https://crbug.com/582149. There's a fix in review (https://codereview.chromium.org/1648113002/) but it probably won't land in time for the next canary. Original issue's description: > Handle pointer-events: none in browser process hittesting. > > This change adds one HittestData structure per surface and a HittestDelegate in RenderWidgetHostInputEventRouter that can reject surfaces based on the HittestData. > > BUG=491334 > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/e6119aac120294a5132703363801033bdad6b2f2 > Cr-Commit-Position: refs/heads/master@{#371691} TBR=dcheng@chromium.org,danakj@chromium.org,enne@chromium.org,piman@chromium.org,vollick@chromium.org,lfg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=491334

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -251 lines) Patch
M cc/surfaces/surface_hittest_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/surfaces/surface_id.h View 2 chunks +0 lines, -8 lines 0 comments Download
M content/browser/compositor/delegated_frame_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/compositor/delegated_frame_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.h View 3 chunks +0 lines, -25 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 3 chunks +1 line, -40 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 2 chunks +2 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 2 chunks +1 line, -74 lines 0 comments Download
M content/common/frame_messages.h View 2 chunks +0 lines, -14 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/child_frame_compositing_helper.h View 4 chunks +1 line, -4 lines 0 comments Download
M content/renderer/child_frame_compositing_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_proxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D content/test/data/frame_tree/page_with_positioned_frame_pointer-events_none.html View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/public/web/WebRemoteFrame.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Charlie Reis
Created Revert of Handle pointer-events: none in browser process hittesting.
4 years, 10 months ago (2016-01-29 00:19:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643063002/1
4 years, 10 months ago (2016-01-29 00:21:14 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 00:24:10 UTC) #4
Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698