Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Unified Diff: content/common/gpu/ca_layer_partial_damage_tree_mac.h

Issue 1643043002: Mac overlays: Clean up partial swap code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate review feedback Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/gpu/ca_layer_partial_damage_tree_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/ca_layer_partial_damage_tree_mac.h
diff --git a/content/common/gpu/ca_layer_partial_damage_tree_mac.h b/content/common/gpu/ca_layer_partial_damage_tree_mac.h
index 5808545885220c3cc02beb4770729fd1275e1798..f52000d6ddfb3ae9a29bf642cce9589e85d3ed18 100644
--- a/content/common/gpu/ca_layer_partial_damage_tree_mac.h
+++ b/content/common/gpu/ca_layer_partial_damage_tree_mac.h
@@ -10,7 +10,6 @@
#include <deque>
#include "base/mac/scoped_cftyperef.h"
-#include "base/memory/linked_ptr.h"
#include "base/memory/scoped_ptr.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/rect_f.h"
@@ -33,14 +32,23 @@ class CALayerPartialDamageTree {
private:
class OverlayPlane;
- void UpdateRootAndPartialDamagePlanes(CALayerPartialDamageTree* old_tree,
- const gfx::RectF& pixel_damage_rect);
- void UpdateRootAndPartialDamageCALayers(CALayer* superlayer,
- float scale_factor);
+ // This will populate |partial_damage_planes_|, potentially re-using the
+ // CALayers and |partial_damage_planes_| from |old_tree|. After this function
+ // completes, the back() of |partial_damage_planes_| is the plane that will
+ // be updated this frame (and if it is empty, then the root plane will be
+ // updated).
+ void UpdatePartialDamagePlanes(CALayerPartialDamageTree* old_tree,
+ const gfx::Rect& pixel_damage_rect);
+
+ void UpdateRootAndPartialDamagePlanes(
+ scoped_ptr<CALayerPartialDamageTree> old_tree,
+ const gfx::Rect& pixel_damage_rect);
+
+ void UpdateCALayers(CALayer* superlayer, float scale_factor);
const bool allow_partial_swap_;
- linked_ptr<OverlayPlane> root_plane_;
- std::deque<linked_ptr<OverlayPlane>> partial_damage_planes_;
+ scoped_ptr<OverlayPlane> root_plane_;
+ std::deque<scoped_ptr<OverlayPlane>> partial_damage_planes_;
};
} // content
« no previous file with comments | « no previous file | content/common/gpu/ca_layer_partial_damage_tree_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698