Issue 1643033002: fixes #25610, infer JS builtin in strong mode like we used to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1643033002: fixes #25610, infer JS builtin in strong mode like we used to (Closed)

Created:
4 years, 10 months ago by Jennifer Messerly

Modified:
4 years, 10 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -13 lines)			Patch
M	pkg/analyzer/lib/src/generated/static_type_analyzer.dart	View	5 chunks	+18 lines, -13 lines	0 comments	Download
M	pkg/analyzer/test/src/task/strong/inferred_type_test.dart	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/task/strong/strong_test_helper.dart	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

Here's the fix. I was able to repro it with a test

4 years, 10 months ago (2016-01-28 22:15:24 UTC) #2

Jennifer Messerly

4 years, 10 months ago (2016-01-28 22:18:30 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9733a88c9fc543e6aa48864b0d31286a5485a26f (presubmit successful).