Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1643023002: Embedded libs key rename to defuse server landmine. (Closed)

Created:
4 years, 10 months ago by pquitslund
Modified:
4 years, 10 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org, keertip
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Embedded libs key rename to defuse server landmine. 1.13 stable builds of the SDK contain a version of server that fails catastrophically when analyzing source that imports packages that define embedded libraries. Since we can't pragmatically require more recent SDKs for flutter development we have been prevented from landing embedded libs in the flutter engine. By renaming the key we use to identify contributed libraries, this change avoids the issue. Old versions of server will simply ignore the new key and new ones will process it properly. Win-win! BUG= R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/9b1fa223a83792756a1dcf4e400e4ae7b1c99917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M pkg/analysis_server/test/context_manager_test.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/source/embedder.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/test/source/embedder_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/test/data/package_with_embedder_yaml/lib/_embedder.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 10 months ago (2016-01-28 21:55:12 UTC) #2
devoncarew
On 2016/01/28 21:55:12, pquitslund wrote: > 1.13 stable builds of the SDK Just to clarify, ...
4 years, 10 months ago (2016-01-28 21:58:45 UTC) #3
danrubel
LGTM
4 years, 10 months ago (2016-01-29 01:40:24 UTC) #4
pquitslund
4 years, 10 months ago (2016-01-29 17:52:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9b1fa223a83792756a1dcf4e400e4ae7b1c99917 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698