Accurately type foreign functions, and variables (attempt 2).

Accurately type foreign functions, and variables (attempt 2).

Associate a type with foreign functions at their callsite.
Associate a type with foreign variables.
More pervasively forbid computation in the module body.
Confirm foreign call arguments are exports.

Pass zone to more Type constructors, for consistency.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N

Committed: https://crrev.com/43be96989f6e9ba9c22c4fe0f46c09c9a5b9cb12
Cr-Commit-Position: refs/heads/master@{#33622}

[bradn, 2016-01-29 18:41:17]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-01-29 18:41:17]

Passing a zone to Type::Number this time.
Rather frightening that not a single trybot catches that.

[bradn, 2016-01-29 20:19:20]

Description was changed from

==========
Accurately type foreign functions, and variables (attempt 2).

Associate a type with foreign functions at their callsite.
Associate a type with foreign variables.
More pervasively forbid computation in the module body.
Confirm foreign call arguments are exports.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N
==========

to

==========
Accurately type foreign functions, and variables (attempt 2).

Associate a type with foreign functions at their callsite.
Associate a type with foreign variables.
More pervasively forbid computation in the module body.
Confirm foreign call arguments are exports.

Pass zone to more Type constructors, for consistency.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N
==========

[aseemgarg, 2016-01-29 20:54:25]

lgtm

https://codereview.chromium.org/1643003004/diff/1/src/typing-asm.h
File src/typing-asm.h (right):

https://codereview.chromium.org/1643003004/diff/1/src/typing-asm.h#newcode165
src/typing-asm.h:165: void VisitVariableProxy(VariableProxy* expr, bool
assignment);
private?

[bradn, 2016-01-29 22:31:08]

https://codereview.chromium.org/1643003004/diff/1/src/typing-asm.h
File src/typing-asm.h (right):

https://codereview.chromium.org/1643003004/diff/1/src/typing-asm.h#newcode165
src/typing-asm.h:165: void VisitVariableProxy(VariableProxy* expr, bool
assignment);
On 2016/01/29 20:54:25, aseemgarg wrote:
> private?

You said that last time :-)
It's already private.

[bradn, 2016-01-29 22:31:12]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2016-01-29 22:31:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1643003004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1643003004/20001

[commit-bot: I haz the power, 2016-01-29 22:32:42]

Description was changed from

==========
Accurately type foreign functions, and variables (attempt 2).

Associate a type with foreign functions at their callsite.
Associate a type with foreign variables.
More pervasively forbid computation in the module body.
Confirm foreign call arguments are exports.

Pass zone to more Type constructors, for consistency.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N
==========

to

==========
Accurately type foreign functions, and variables (attempt 2).

Associate a type with foreign functions at their callsite.
Associate a type with foreign variables.
More pervasively forbid computation in the module body.
Confirm foreign call arguments are exports.

Pass zone to more Type constructors, for consistency.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N
==========

[commit-bot: I haz the power, 2016-01-29 22:32:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-29 22:33:12]

Description was changed from

==========
Accurately type foreign functions, and variables (attempt 2).

Associate a type with foreign functions at their callsite.
Associate a type with foreign variables.
More pervasively forbid computation in the module body.
Confirm foreign call arguments are exports.

Pass zone to more Type constructors, for consistency.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N
==========

to

==========
Accurately type foreign functions, and variables (attempt 2).

Associate a type with foreign functions at their callsite.
Associate a type with foreign variables.
More pervasively forbid computation in the module body.
Confirm foreign call arguments are exports.

Pass zone to more Type constructors, for consistency.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N

Committed: https://crrev.com/43be96989f6e9ba9c22c4fe0f46c09c9a5b9cb12
Cr-Commit-Position: refs/heads/master@{#33622}
==========

[commit-bot: I haz the power, 2016-01-29 22:33:12]

Patchset 2 (id:??) landed as
https://crrev.com/43be96989f6e9ba9c22c4fe0f46c09c9a5b9cb12
Cr-Commit-Position: refs/heads/master@{#33622}