Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 1643003003: Skip flatten tests (Closed)

Created:
4 years, 10 months ago by vsm
Modified:
4 years, 10 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M test/codegen/language/flatten_test.dart View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vsm
4 years, 10 months ago (2016-01-28 22:13:42 UTC) #2
Jennifer Messerly
Another approach here is to just add trailing comments like: /// 42: compile-time error /// ...
4 years, 10 months ago (2016-01-28 22:17:35 UTC) #3
Jennifer Messerly
either way, lgtm
4 years, 10 months ago (2016-01-28 22:23:33 UTC) #4
vsm
4 years, 10 months ago (2016-01-28 22:24:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ae4f28d51a795565fb0a7b2789ec15776eeff8c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698