Resynthesize untyped List / Map.

Resynthesize untyped List / Map.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/371922dc670e0d606a8866286614fecfcef72233

[Paul Berry, 2016-01-28 23:43:07]

lgtm with one nit

https://codereview.chromium.org/1642993003/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_test.dart (right):

https://codereview.chromium.org/1642993003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:236:
originalMap.forEach((originalKey, originalValue) {
In Dart, maps are ordered, so there are subtle semantic differences between
e.g.:

    const a = const { 1: 2, 3: 4 }

and:

    const b = const { 3: 4, 1: 2 }

which are detectable at runtime.  This code should make sure that not only does
the key/value mapping match, but the order of keys matches too.

[scheglov, 2016-01-29 17:07:08]

https://codereview.chromium.org/1642993003/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_test.dart (right):

https://codereview.chromium.org/1642993003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:236:
originalMap.forEach((originalKey, originalValue) {
On 2016/01/28 23:43:07, Paul Berry wrote:
> In Dart, maps are ordered, so there are subtle semantic differences between
> e.g.:
> 
>     const a = const { 1: 2, 3: 4 }
> 
> and:
> 
>     const b = const { 3: 4, 1: 2 }
> 
> which are detectable at runtime.  This code should make sure that not only
does
> the key/value mapping match, but the order of keys matches too.

Thanks, I will add better validation.
It turned out that the constant computer returns not ordered HashMap.
This CL should fix the problem: https://codereview.chromium.org/1643253002/

[scheglov, 2016-01-29 17:39:22]

Description was changed from

==========
Resynthesize untyped List / Map.

R=paulberry@google.com
BUG=
==========

to

==========
Resynthesize untyped List / Map.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/371922dc670e0d606a8866286614fecfcef72233
==========

[scheglov, 2016-01-29 17:39:23]

Committed patchset #2 (id:20001) manually as
371922dc670e0d606a8866286614fecfcef72233 (presubmit successful).