Accurately type foreign functions, and variables.

src/typing-asm.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_TYPING_ASM_H_
 #define V8_TYPING_ASM_H_
 
 #include "src/allocation.h"
 #include "src/ast/ast.h"
 #include "src/effects.h"
@@ skipping 95 matching lines @@
   VariableInfo* stdlib_simd_##name##_constructor_type_;
   SIMD128_TYPES(V)
 #undef V
 
   // Map from Variable* to global/local variable Type*.
   ZoneHashMap global_variable_type_;
   ZoneHashMap local_variable_type_;
 
   bool in_function_;  // In module function?
   bool building_function_tables_;
+  bool visiting_exports_;
 
   TypeCache const& cache_;
 
   static const int kErrorMessageLimit = 100;
   char error_message_[kErrorMessageLimit];
 
   static const int kMaxUncombinedAdditiveSteps = 1 << 20;
   static const int kMaxUncombinedMultiplicativeSteps = 1;
 
   void InitializeStdlib();
@@ skipping 28 matching lines @@
   void VisitLibraryAccess(ObjectTypeMap* map, Property* expr);
 
   void SetResult(Expression* expr, Type* type);
   void IntersectResult(Expression* expr, Type* type);
 
   void VisitWithExpectation(Expression* expr, Type* expected_type,
                             const char* msg);
 
   void VisitLiteral(Literal* expr, bool is_return);
 
+  void VisitVariableProxy(VariableProxy* expr, bool assignment);

[aseemgarg, 2016/01/28 23:09:59]

make this private?

[bradn, 2016/01/29 01:03:38]

It is?

+
   void VisitIntegerBitwiseOperator(BinaryOperation* expr, Type* left_expected,
                                    Type* right_expected, Type* result_type,
                                    bool conversion);
 
   Zone* zone() const { return zone_; }
 
 #define DECLARE_VISIT(type) void Visit##type(type* node) override;
   AST_NODE_LIST(DECLARE_VISIT)
 #undef DECLARE_VISIT
 
   DISALLOW_COPY_AND_ASSIGN(AsmTyper);
 };
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TYPING_ASM_H_