Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1642983002:
Cleanup: Remove unused declaration of __libc_stack_end (Closed)
|
Created:
4 years, 10 months ago by Mark Seaborn Modified:
4 years, 10 months ago CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org Base URL:
http://git.chromium.org/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCleanup: Remove unused declaration of __libc_stack_end
The use was moved to StackFrameDepth.cpp by an earlier change.
BUG=420515
TEST=build
Committed: https://crrev.com/6594bbe3a6c056d9277c4c2e0b9fdb6d7f28ff8a
Cr-Commit-Position: refs/heads/master@{#372182}
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
The CQ bit was checked by mseaborn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642983002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Cleanup: Remove unused declaration of __libc_stack_end The use was moved to StackFrameDepth.cpp by an earlier change. BUG=420515 TEST=build ========== to ========== Cleanup: Remove unused declaration of __libc_stack_end The use was moved to StackFrameDepth.cpp by an earlier change. BUG=420515 TEST=build ==========
mseaborn@chromium.org changed reviewers: + peria@chromium.org
sigbjornf@opera.com changed reviewers: + sigbjornf@opera.com
lgtm
mseaborn@chromium.org changed reviewers: + haraken@chromium.org
+haraken for OWNERS sign off
On 2016/01/28 21:50:44, Mark Seaborn wrote: > +haraken for OWNERS sign off not needed :)
The CQ bit was checked by mseaborn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642983002/1
Message was sent while issue was closed.
Description was changed from ========== Cleanup: Remove unused declaration of __libc_stack_end The use was moved to StackFrameDepth.cpp by an earlier change. BUG=420515 TEST=build ========== to ========== Cleanup: Remove unused declaration of __libc_stack_end The use was moved to StackFrameDepth.cpp by an earlier change. BUG=420515 TEST=build ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Cleanup: Remove unused declaration of __libc_stack_end The use was moved to StackFrameDepth.cpp by an earlier change. BUG=420515 TEST=build ========== to ========== Cleanup: Remove unused declaration of __libc_stack_end The use was moved to StackFrameDepth.cpp by an earlier change. BUG=420515 TEST=build Committed: https://crrev.com/6594bbe3a6c056d9277c4c2e0b9fdb6d7f28ff8a Cr-Commit-Position: refs/heads/master@{#372182} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6594bbe3a6c056d9277c4c2e0b9fdb6d7f28ff8a Cr-Commit-Position: refs/heads/master@{#372182}
Message was sent while issue was closed.
LGTM |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
