SourceFactory interface extraction.

SourceFactory interface extraction.

Prerequisite to accessing resolvers to handle embedder analysis changes.

See: https://github.com/dart-lang/sdk/issues/25606

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/ce0c3343a726fc392573362a4dc6f580ff396336

[pquitslund, 2016-01-28 18:50:06]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-01-28 18:55:41]

LGTM

https://codereview.chromium.org/1642973002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/source.dart (right):

https://codereview.chromium.org/1642973002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/source.dart:1: // Copyright (c) 2016, the Dart
project authors.  Please see the AUTHORS file
I've been preserving the copyright from the original file when extracting code
to a new file. Not sure it's important.

https://codereview.chromium.org/1642973002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/source.dart:22: class SourceFactoryImpl implements
SourceFactory {
I'm assuming this was just copied and renamed from the old version of
SourceFactory. If there are changes I should look at, let me know.

[pquitslund, 2016-01-28 18:57:33]

Description was changed from

==========
SourceFactory interface extraction.

Prerequisite to accessing resolvers to handle embedder analysis changes.

See: https://github.com/dart-lang/sdk/issues/25606

BUG=
==========

to

==========
SourceFactory interface extraction.

Prerequisite to accessing resolvers to handle embedder analysis changes.

See: https://github.com/dart-lang/sdk/issues/25606

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ce0c3343a726fc392573362a4dc6f580ff396336
==========

[pquitslund, 2016-01-28 18:57:35]

Committed patchset #1 (id:1) manually as
ce0c3343a726fc392573362a4dc6f580ff396336 (presubmit successful).

[pquitslund, 2016-01-28 18:58:20]

Thanks!

https://codereview.chromium.org/1642973002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/source.dart (right):

https://codereview.chromium.org/1642973002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/source.dart:1: // Copyright (c) 2016, the Dart
project authors.  Please see the AUTHORS file
On 2016/01/28 18:55:41, Brian Wilkerson wrote:
> I've been preserving the copyright from the original file when extracting code
> to a new file. Not sure it's important.

Done.

https://codereview.chromium.org/1642973002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/source.dart:22: class SourceFactoryImpl implements
SourceFactory {
On 2016/01/28 18:55:41, Brian Wilkerson wrote:
> I'm assuming this was just copied and renamed from the old version of
> SourceFactory. If there are changes I should look at, let me know.

Nope.  _resolvers => resolvers is all.