Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: third_party/WebKit/Source/core/css/CSSFontSelector.cpp

Issue 1642913002: Speculatively handle weak member clearing while creating iteration vector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSFontSelector.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSFontSelector.cpp b/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
index da4476d005dc497f32e01316c19864197b2591fb..1719ae944ed8620057dc18ebeee729455083a8b1 100644
--- a/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
+++ b/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
@@ -83,8 +83,12 @@ void CSSFontSelector::dispatchInvalidationCallbacks()
WillBeHeapVector<RawPtrWillBeMember<CSSFontSelectorClient>> clients;
copyToVector(m_clients, clients);
- for (size_t i = 0; i < clients.size(); ++i)
- clients[i]->fontsNeedUpdate(this);
+ // TODO(sof): the null check is temporarily in place to speculatively address
+ // crbug.com/568173.
+ for (auto& client : clients) {
+ if (client)
+ client->fontsNeedUpdate(this);
+ }
}
void CSSFontSelector::fontFaceInvalidated()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698