[interpreter] Refactor iterator access in BytecodeGraphBuilder.

[interpreter] Refactor iterator access in BytecodeGraphBuilder.

This refactors how the BytecodeArrayIterator is passed to visitation
methods on the BytecodeGraphBuilder. We no longer pass it explicitly,
but use the field accessor instead. Note that const-ness is still
preserved and visitation methods are still not able to mutate the
iterator. The main goal of this refactoring is increased readability.

R=rmcilroy@chromium.org

Committed: https://crrev.com/579264e359ade615ff64d56d640eed964fb5ce04
Cr-Commit-Position: refs/heads/master@{#33607}

[rmcilroy, 2016-01-28 18:15:05]

Lgtm with a renaming suggestion. Thanks!

https://codereview.chromium.org/1642893004/diff/1/src/compiler/bytecode-graph...
File src/compiler/bytecode-graph-builder.h (right):

https://codereview.chromium.org/1642893004/diff/1/src/compiler/bytecode-graph...
src/compiler/bytecode-graph-builder.h:208: const
interpreter::BytecodeArrayIterator& iterator() const {
Nit - could you call this bytecodes_iterator()

[Michael Starzinger, 2016-01-28 18:28:48]

Description was changed from

==========
[interpreter] Refactor iterator access in BytecodeGraphBuilder.

This refactors how the BytecodeArrayIterator is passed to visitation
methods on the BytecodeGraphBuilder. We no longer pass is explicitly,
but use the field accessor instead. Note that const-ness is still
preserved and visitation methods are still not able to mutate the
iterator. The main goal of this refactoring is increased readability.

R=rmcilroy@chromium.org,oth@chromium.org
==========

to

==========
[interpreter] Refactor iterator access in BytecodeGraphBuilder.

This refactors how the BytecodeArrayIterator is passed to visitation
methods on the BytecodeGraphBuilder. We no longer pass ii explicitly,
but use the field accessor instead. Note that const-ness is still
preserved and visitation methods are still not able to mutate the
iterator. The main goal of this refactoring is increased readability.

R=rmcilroy@chromium.org,oth@chromium.org
==========

[Michael Starzinger, 2016-01-28 21:23:40]

Description was changed from

==========
[interpreter] Refactor iterator access in BytecodeGraphBuilder.

This refactors how the BytecodeArrayIterator is passed to visitation
methods on the BytecodeGraphBuilder. We no longer pass ii explicitly,
but use the field accessor instead. Note that const-ness is still
preserved and visitation methods are still not able to mutate the
iterator. The main goal of this refactoring is increased readability.

R=rmcilroy@chromium.org,oth@chromium.org
==========

to

==========
[interpreter] Refactor iterator access in BytecodeGraphBuilder.

This refactors how the BytecodeArrayIterator is passed to visitation
methods on the BytecodeGraphBuilder. We no longer pass it explicitly,
but use the field accessor instead. Note that const-ness is still
preserved and visitation methods are still not able to mutate the
iterator. The main goal of this refactoring is increased readability.

R=rmcilroy@chromium.org,oth@chromium.org
==========

[Michael Starzinger, 2016-01-29 09:42:04]

Thanks. Addressed comment. Landing.

https://codereview.chromium.org/1642893004/diff/1/src/compiler/bytecode-graph...
File src/compiler/bytecode-graph-builder.h (right):

https://codereview.chromium.org/1642893004/diff/1/src/compiler/bytecode-graph...
src/compiler/bytecode-graph-builder.h:208: const
interpreter::BytecodeArrayIterator& iterator() const {
On 2016/01/28 18:15:04, rmcilroy wrote:
> Nit - could you call this bytecodes_iterator()

Done.

[Michael Starzinger, 2016-01-29 09:42:13]

Description was changed from

==========
[interpreter] Refactor iterator access in BytecodeGraphBuilder.

This refactors how the BytecodeArrayIterator is passed to visitation
methods on the BytecodeGraphBuilder. We no longer pass it explicitly,
but use the field accessor instead. Note that const-ness is still
preserved and visitation methods are still not able to mutate the
iterator. The main goal of this refactoring is increased readability.

R=rmcilroy@chromium.org,oth@chromium.org
==========

to

==========
[interpreter] Refactor iterator access in BytecodeGraphBuilder.

This refactors how the BytecodeArrayIterator is passed to visitation
methods on the BytecodeGraphBuilder. We no longer pass it explicitly,
but use the field accessor instead. Note that const-ness is still
preserved and visitation methods are still not able to mutate the
iterator. The main goal of this refactoring is increased readability.

R=rmcilroy@chromium.org
==========

[Michael Starzinger, 2016-01-29 10:10:03]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-01-29 10:10:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1642893004/#ps60001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-01-29 10:10:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1642893004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1642893004/60001

[commit-bot: I haz the power, 2016-01-29 10:15:31]

Description was changed from

==========
[interpreter] Refactor iterator access in BytecodeGraphBuilder.

This refactors how the BytecodeArrayIterator is passed to visitation
methods on the BytecodeGraphBuilder. We no longer pass it explicitly,
but use the field accessor instead. Note that const-ness is still
preserved and visitation methods are still not able to mutate the
iterator. The main goal of this refactoring is increased readability.

R=rmcilroy@chromium.org
==========

to

==========
[interpreter] Refactor iterator access in BytecodeGraphBuilder.

This refactors how the BytecodeArrayIterator is passed to visitation
methods on the BytecodeGraphBuilder. We no longer pass it explicitly,
but use the field accessor instead. Note that const-ness is still
preserved and visitation methods are still not able to mutate the
iterator. The main goal of this refactoring is increased readability.

R=rmcilroy@chromium.org
==========

[commit-bot: I haz the power, 2016-01-29 10:15:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-29 10:15:49]

Description was changed from

==========
[interpreter] Refactor iterator access in BytecodeGraphBuilder.

This refactors how the BytecodeArrayIterator is passed to visitation
methods on the BytecodeGraphBuilder. We no longer pass it explicitly,
but use the field accessor instead. Note that const-ness is still
preserved and visitation methods are still not able to mutate the
iterator. The main goal of this refactoring is increased readability.

R=rmcilroy@chromium.org
==========

to

==========
[interpreter] Refactor iterator access in BytecodeGraphBuilder.

This refactors how the BytecodeArrayIterator is passed to visitation
methods on the BytecodeGraphBuilder. We no longer pass it explicitly,
but use the field accessor instead. Note that const-ness is still
preserved and visitation methods are still not able to mutate the
iterator. The main goal of this refactoring is increased readability.

R=rmcilroy@chromium.org

Committed: https://crrev.com/579264e359ade615ff64d56d640eed964fb5ce04
Cr-Commit-Position: refs/heads/master@{#33607}
==========

[commit-bot: I haz the power, 2016-01-29 10:15:50]

Patchset 4 (id:??) landed as
https://crrev.com/579264e359ade615ff64d56d640eed964fb5ce04
Cr-Commit-Position: refs/heads/master@{#33607}