Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 1642883002: Add a note to OilpanLeakExpectations for future gardeners (Closed)

Created:
4 years, 10 months ago by Noel Gordon
Modified:
4 years, 10 months ago
Reviewers:
haraken, sof
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a note to OilpanLeakExpectations for future gardeners TBR=haraken@chromium.org NOPRESUBMIT=true NOTRY=true BUG=581987 Committed: https://crrev.com/a90bce019bd99ee96329b348d32260203b37a132 Cr-Commit-Position: refs/heads/master@{#372062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/OilpanLeakExpectations View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642883002/1
4 years, 10 months ago (2016-01-28 10:09:37 UTC) #4
Noel Gordon
Should not be too hard to add a note to the various Oilpan expectation files ...
4 years, 10 months ago (2016-01-28 10:10:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 10:10:57 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a90bce019bd99ee96329b348d32260203b37a132 Cr-Commit-Position: refs/heads/master@{#372062}
4 years, 10 months ago (2016-01-28 10:11:57 UTC) #9
sof
lgtm, thanks.
4 years, 10 months ago (2016-01-28 10:33:26 UTC) #11
haraken
4 years, 10 months ago (2016-01-28 10:50:15 UTC) #12
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698