Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 1642863002: Let notifyScriptLoadError() handle already detached ScriptLoaders. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let notifyScriptLoadError() handle already detached ScriptLoaders. If a ScriptRunner has been disposed of already, allow ScriptLoaders to notify of their failure without asserting. R=haraken BUG=570012 Committed: https://crrev.com/282119e0905e8fbb0024e7341e0ae48eb406d2de Cr-Commit-Position: refs/heads/master@{#372075}

Patch Set 1 #

Patch Set 2 : rebased up to r372058 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptRunner.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.cpp View 1 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
sof
please take a look. To ease backporting, I suggest we do this instead..but after having ...
4 years, 10 months ago (2016-01-28 09:20:06 UTC) #2
haraken
LGTM
4 years, 10 months ago (2016-01-28 09:23:41 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642863002/20001
4 years, 10 months ago (2016-01-28 10:00:49 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-28 11:35:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642863002/20001
4 years, 10 months ago (2016-01-28 11:44:01 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 11:48:49 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 11:49:36 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/282119e0905e8fbb0024e7341e0ae48eb406d2de
Cr-Commit-Position: refs/heads/master@{#372075}

Powered by Google App Engine
This is Rietveld 408576698