|
|
Created:
6 years, 10 months ago by timvolodine Modified:
6 years, 9 months ago Reviewers:
Michael van Ouwerkerk CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Michael van Ouwerkerk Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionMac: fix Device Orientation absolute property and handle the no-sensor case.
On the Mac platform we cannot provide absolute Device Orientation
angles, because the alpha angle cannot be computed using the
Mac's Sudden Motion Sensor.
The patch also handles the case if there is no sensor available.
In that case we propagate a one-shot all-null event as per
specification.
BUG=136010
TEST=http://jsbin.com/device-inertial-sensor-diagnostics/latest (manual)
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260032
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 22 (0 generated)
lgtm but why no tests?
On 2014/02/17 13:40:15, Michael van Ouwerkerk wrote: > lgtm but why no tests? Currently the tests are manual as noted in the description. Due to relative simplicity of the implementation for the Mac platform (as compared to Android) there is no specific unittest yet (I've created a crbug.com/344353 for this though).
The CQ bit was checked by timvolodine@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/164283009/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
The CQ bit was checked by timvolodine@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/164283009/90001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
The CQ bit was checked by timvolodine@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/164283009/90001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by timvolodine@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/164283009/90001
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
The CQ bit was checked by timvolodine@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/164283009/90001
Message was sent while issue was closed.
Change committed as 260032 |