Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 164283009: Mac: fix Device Orientation absolute property and handle the no-sensor case. (Closed)

Created:
6 years, 10 months ago by timvolodine
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Michael van Ouwerkerk
Visibility:
Public.

Description

Mac: fix Device Orientation absolute property and handle the no-sensor case. On the Mac platform we cannot provide absolute Device Orientation angles, because the alpha angle cannot be computed using the Mac's Sudden Motion Sensor. The patch also handles the case if there is no sensor available. In that case we propagate a one-shot all-null event as per specification. BUG=136010 TEST=http://jsbin.com/device-inertial-sensor-diagnostics/latest (manual) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260032

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M content/browser/device_orientation/data_fetcher_shared_memory_mac.cc View 2 chunks +26 lines, -11 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
timvolodine
6 years, 10 months ago (2014-02-16 21:54:08 UTC) #1
Michael van Ouwerkerk
lgtm but why no tests?
6 years, 10 months ago (2014-02-17 13:40:15 UTC) #2
timvolodine
On 2014/02/17 13:40:15, Michael van Ouwerkerk wrote: > lgtm but why no tests? Currently the ...
6 years, 10 months ago (2014-02-17 14:58:27 UTC) #3
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 9 months ago (2014-03-27 15:02:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/164283009/1
6 years, 9 months ago (2014-03-27 15:02:37 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 15:22:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 9 months ago (2014-03-27 15:22:06 UTC) #7
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 9 months ago (2014-03-27 16:18:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/164283009/90001
6 years, 9 months ago (2014-03-27 16:19:52 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 16:36:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 9 months ago (2014-03-27 16:36:37 UTC) #11
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 9 months ago (2014-03-27 18:17:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/164283009/90001
6 years, 9 months ago (2014-03-27 18:17:14 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 20:11:51 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=289611
6 years, 9 months ago (2014-03-27 20:11:53 UTC) #15
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 9 months ago (2014-03-27 21:09:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/164283009/90001
6 years, 9 months ago (2014-03-27 21:12:32 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 22:27:12 UTC) #18
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 22:27:13 UTC) #19
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 9 months ago (2014-03-27 23:53:39 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/164283009/90001
6 years, 9 months ago (2014-03-27 23:54:58 UTC) #21
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 23:58:20 UTC) #22
Message was sent while issue was closed.
Change committed as 260032

Powered by Google App Engine
This is Rietveld 408576698