Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1642823002: [turbofan] Jump threading awareness of frame elision. (Closed)

Created:
4 years, 10 months ago by Mircea Trofin
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Preparing the terrain for frame elision. This change is necessary to avoid jump threading erasing the reconstruction of a frame, if the frame was elided. BUG= Committed: https://crrev.com/d1083526a65736c2a3d9ad6a0ded699c37d2f183 Cr-Commit-Position: refs/heads/master@{#33590}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M src/compiler/jump-threading.h View 1 chunk +1 line, -1 line 1 comment Download
M src/compiler/jump-threading.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M src/compiler/pipeline.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +11 lines, -4 lines 1 comment Download
M test/cctest/compiler/test-jump-threading.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Mircea Trofin
4 years, 10 months ago (2016-01-28 03:27:08 UTC) #3
Jarin
lgtm (assuming the monster condition is moved from the pipeline to the register allocator). https://codereview.chromium.org/1642823002/diff/1/src/compiler/jump-threading.h ...
4 years, 10 months ago (2016-01-28 05:26:59 UTC) #4
Mircea Trofin
On 2016/01/28 05:26:59, Jarin wrote: > lgtm (assuming the monster condition is moved from the ...
4 years, 10 months ago (2016-01-28 05:36:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642823002/1
4 years, 10 months ago (2016-01-28 16:11:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 16:14:45 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 16:15:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1083526a65736c2a3d9ad6a0ded699c37d2f183
Cr-Commit-Position: refs/heads/master@{#33590}

Powered by Google App Engine
This is Rietveld 408576698