Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 16428002: Remove [NoInterfaceObject] from TreeWalker interface (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, lgombos
Visibility:
Public.

Description

Remove [NoInterfaceObject] from TreeWalker interface Remove [NoInterfaceObject] from TreeWalker interface to match Firefox's behavior and the specification: http://www.w3.org/TR/DOM-Level-2-Traversal-Range/traversal.html#Traversal-TreeWalker Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151833

Patch Set 1 #

Patch Set 2 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M LayoutTests/fast/dom/dom-constructors-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/TreeWalker.idl View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-05 06:52:09 UTC) #1
haraken
LGTM
7 years, 6 months ago (2013-06-05 07:18:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/16428002/1
7 years, 6 months ago (2013-06-05 07:41:19 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/dom/dom-constructors-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-05 08:48:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/16428002/9001
7 years, 6 months ago (2013-06-05 10:29:30 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-05 12:14:44 UTC) #6
Message was sent while issue was closed.
Change committed as 151833

Powered by Google App Engine
This is Rietveld 408576698