Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 164279: View Background Image Feature (Closed)

Created:
11 years, 4 months ago by steveisok
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), jam, Ben Goodger (Google)
Visibility:
Public.

Description

BUG=746 TEST=none Initial proof of concept for the right-click context menu "View Background Image" feature. This patch is intended to confirm if I'm on the right track and get feedback on things I could focus on. Also, I only focused on Windows for this particular implementation. I don't have a MAC and I haven't yet fired up any Linux distro, so I would probably need help there.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.h View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 2 chunks +39 lines, -0 lines 0 comments Download
M webkit/glue/context_menu.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/context_menu_client_impl.cc View 7 chunks +50 lines, -2 lines 0 comments Download
M webkit/glue/webview_delegate.h View 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
steveisok
11 years, 4 months ago (2009-08-11 04:17:25 UTC) #1
Peter Kasting
Drive-by: In the future please put BUG=, TEST= and similar at the bottom of your ...
11 years, 4 months ago (2009-08-11 17:35:25 UTC) #2
steveisok
Sorry! I noticed that after the fact. Will change in the future. On Tue, Aug ...
11 years, 4 months ago (2009-08-11 17:37:29 UTC) #3
Peter Kasting
Also: I question whether we actually want this. CCed Ben on the bug in hopes ...
11 years, 4 months ago (2009-08-11 17:37:38 UTC) #4
brettw
In my opinion, we don't want this feature. If we do, I don't think we ...
11 years, 4 months ago (2009-08-11 17:47:33 UTC) #5
steveisok
Agreed on the duplicate context menu function... I was only trying to get a proof ...
11 years, 4 months ago (2009-08-11 18:05:34 UTC) #6
Peter Kasting
Closed because bug is WontFix.
11 years, 4 months ago (2009-08-21 01:18:22 UTC) #7
heavymark
11 years, 1 month ago (2009-11-04 16:36:03 UTC) #8
For the rest of the web developer world who does need this feature like all
Firefox users, can we use these files to install it on our own? Or turn it into
a plugin for web developers to install?

Powered by Google App Engine
This is Rietveld 408576698