Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/test/chromedriver/window_commands.cc

Issue 1642773002: [chromedriver] Remove warning message for GetCurrentUrl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/window_commands.cc
diff --git a/chrome/test/chromedriver/window_commands.cc b/chrome/test/chromedriver/window_commands.cc
index 786f185b01ace9da3dc4ac7cd33df406425325fd..ff0be7fa2c2e8505d49f6d99f16f715a51593886 100644
--- a/chrome/test/chromedriver/window_commands.cc
+++ b/chrome/test/chromedriver/window_commands.cc
@@ -467,14 +467,6 @@ Status ExecuteGetCurrentUrl(
return status;
}
}
- if (!session->GetCurrentFrameId().empty()) {
- // TODO(samuong): remove this after we release ChromeDriver 2.21.
- LOG(WARNING)
- << "As of ChromeDriver 2.21, GetCurrentUrl now returns the "
- "URL of the top-level browsing context, not the current frame. "
- "See https://code.google.com/p/chromedriver/issues/detail?id=1249 "
- "for details and workarounds.";
- }
value->reset(new base::StringValue(url));
return Status(kOk);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698