Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1642763002: tools/battor_agent: Adds a tool to find connected BattOrs (Closed)

Created:
4 years, 11 months ago by charliea (OOO until 10-5)
Modified:
4 years, 11 months ago
Reviewers:
Zhen Wang, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/battor_agent: Adds a tool to find connected BattOrs This is a resubmission of https://codereview.chromium.org/1631313002/. Since then, the //device/serial dependencies have been fixed. This tool will also be used by the Chromium trace controller to find any connected BattOrs. TBR=zhenw@chromium.org,sky@chromium.org BUG=542837 Committed: https://crrev.com/03ade5bf2b3e78620c6887d7e1fd19113059aaae Cr-Commit-Position: refs/heads/master@{#371891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -4 lines) Patch
M tools/battor_agent/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/battor_agent/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M tools/battor_agent/battor_agent.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/battor_agent/battor_agent_bin.cc View 4 chunks +20 lines, -4 lines 0 comments Download
M tools/battor_agent/battor_agent_unittest.cc View 6 chunks +8 lines, -0 lines 0 comments Download
A tools/battor_agent/battor_finder.h View 1 chunk +23 lines, -0 lines 0 comments Download
A tools/battor_agent/battor_finder.cc View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
charliea (OOO until 10-5)
4 years, 11 months ago (2016-01-27 21:35:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642763002/1
4 years, 11 months ago (2016-01-27 21:36:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 22:17:48 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 22:19:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03ade5bf2b3e78620c6887d7e1fd19113059aaae
Cr-Commit-Position: refs/heads/master@{#371891}

Powered by Google App Engine
This is Rietveld 408576698