Mask the close button on the download shelf so that it's visible even in dark...

Mask the close button on the download shelf so that it's visible even in dark themes.

BUG= http://crbug.com/18451
TEST= Install a dark theme, cause download shelf to appear, note that the close button is visible.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22980

[Glen Murphy, 2009-08-10 23:21:54]

http://codereview.chromium.org/164276/diff/10/1001
File chrome/browser/views/download_shelf_view.cc (right):

http://codereview.chromium.org/164276/diff/10/1001#newcode109
Line 109: close_button_->SetBackground(close_button_color_,
1. I don't think you need to keep close_button_color_ around, especially since
you're querying for it anyway. This will also be necessary becauuusee:

2. This code doesn't account for themes changing (need to reset the button color
on view::ThemeChanged).

[Miranda Callahan, 2009-08-10 23:45:58]

http://codereview.chromium.org/164276/diff/10/1001
File chrome/browser/views/download_shelf_view.cc (right):

http://codereview.chromium.org/164276/diff/10/1001#newcode109
Line 109: close_button_->SetBackground(close_button_color_,
Whoops!  Changes of mind accounted for, and superfluous variable discarded.

On 2009/08/10 23:21:54, Glen Murphy wrote:
> 1. I don't think you need to keep close_button_color_ around, especially since
> you're querying for it anyway. This will also be necessary becauuusee:
> 
> 2. This code doesn't account for themes changing (need to reset the button
color
> on view::ThemeChanged).

[Glen Murphy, 2009-08-10 23:50:22]

Bonza. LGTM

[tony, 2009-08-11 00:05:28]

Out of curiosity, would it have been hard to make this a tinted button like the
toolbar buttons?  That way linux/mac would get to share more code with windows.